Persist phishing state controller state.

[segun]

Explanation

In MV3, when you restart Metamask (or when SW restarts), all the phishing lists are not loaded. This means some phishing sites are not blocked on the first run after a restart.

This PR fixes this issue by persisting PhishingController state.

• Fixes [Bug]: [MV3] Loading a detected phishing page for the first time does not show the phishing page warning #16551
• See: [Bug]: [MV3] Loading a detected phishing page for the first time does not show the phishing page warning #16551 for more information and repro steps.
• Blocked By: PR

Manual Testing Steps

1. Start MM in mv3 mode yarn start:mv3
2. Load MM extension
3. Load MM UI
4. Go to https://poccoinss.com/ or https://polygonteechnology.info
5. The page should load without the phishing warning the first time you load metamask
6. Loading the page again, you should see the Phishing Warning page
7. Go to extension manager and click on the refresh button to reload metamask
8. Go to https://poccoinss.com/ or https://polygonteechnology.info
9. The page should load without the phishing warning the first time you load metamask
10. Loading the page again, you should see the Phishing Warning page
11. Checkout this branch and start MM in mv3 mode
12. Repeat the above steps, refresh MM from Extensions Manager and load the phishing pages
13. You should see the phishing warning immediately.

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [4d5f120]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1548 ± 122 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	172	129	20	10
		domContentLoaded	1265	2161	1524	243	117
		load	1292	2280	1548	254	122
		domInteractive	1265	2161	1524	243	117

Bundle size diffs [🚀 Bundle size reduced!]

• background: -7998 bytes
• ui: 0 bytes
• common: 0 bytes

[metamaskbot]

Builds ready [1b2d3bf]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1574 ± 116 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	105	196	136	24	12
		domContentLoaded	1198	2112	1549	234	112
		load	1198	2112	1574	242	116
		domInteractive	1198	2112	1549	234	112

Bundle size diffs [🚀 Bundle size reduced!]

• background: -8021 bytes
• ui: 0 bytes
• common: 0 bytes

[brad-decker]

LGTM