Move account export into own view #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account detail view now has an animated transitioning `subview` section that allows us to show extra details within it. Clicking `export` now slide replaces the transaction list with the export UI. Added cancel/done/submit buttons to the Export UI. Done submits like Enter did, the other two transition back to the transaction list. For some reason when first unlocking, the selected account is being instantly replaced with the accounts list, so I need to fix that before merging this into master.
danfinlay
changed the title
Where sometimes the account list was shown when first unlocking, after momentarily showing the detail panel.
yqrashawn
added a commit
to yqrashawn/conflux-portal
that referenced
this pull request
Jul 3, 2020
SeungjunWe
pushed a commit
to DcentWallet/metamask-extension
that referenced
this pull request
Jul 13, 2020
(Fix) Remove unused deps
This was referenced Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account detail view now has an animated transitioning
subviewsection that allows us to show extra details within it.Clicking
exportnow slide replaces the transaction list with the export UI.Added cancel/done/submit buttons to the Export UI. Done submits like Enter did, the other two transition back to the transaction list.
For some reason when first unlocking, the selected account is being instantly replaced with the accounts list, so I wanted to fix that before merging this into master, but now I realize that bug is on master too, so I've opened it as Issue #170, and I'm calling this ready to merge.
Fixes #166
Fixes #170
Improved #160 although each transition requires some care on its own to prevent similar glitches.