-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump contract metadata package version #18278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
DDDDDanica
previously approved these changes
Mar 22, 2023
pedronfigueiredo
force-pushed
the
feat/bump-contract-metadata
branch
from
March 22, 2023 17:04
488c329
to
7f4cc3b
Compare
pedronfigueiredo
force-pushed
the
feat/bump-contract-metadata
branch
from
March 22, 2023 17:26
7f4cc3b
to
b13203b
Compare
NidhiKJha
approved these changes
Mar 22, 2023
Builds ready [b13203b]
Page Load Metrics (1642 ± 57 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov Report
@@ Coverage Diff @@
## develop #18278 +/- ##
========================================
Coverage 64.49% 64.49%
========================================
Files 910 910
Lines 35281 35281
Branches 9037 9037
========================================
Hits 22751 22751
Misses 12530 12530 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brad-decker
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Bumping contract-metadata version following up on:
MetaMask/contract-metadata#1169
MetaMask/contract-metadata#1173
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.