Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump contract metadata package version #18278

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Mar 22, 2023

Explanation

Bumping contract-metadata version following up on:

MetaMask/contract-metadata#1169
MetaMask/contract-metadata#1173

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

DDDDDanica
DDDDDanica previously approved these changes Mar 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [b13203b]
Page Load Metrics (1642 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101147123147
domContentLoaded14571906162710651
load14571906164212057
domInteractive14571906162710651
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 0 bytes
  • common: 1291 bytes

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #18278 (b13203b) into develop (ca72ab7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #18278   +/-   ##
========================================
  Coverage    64.49%   64.49%           
========================================
  Files          910      910           
  Lines        35281    35281           
  Branches      9037     9037           
========================================
  Hits         22751    22751           
  Misses       12530    12530           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pedronfigueiredo pedronfigueiredo merged commit 34ba624 into develop Mar 22, 2023
@pedronfigueiredo pedronfigueiredo deleted the feat/bump-contract-metadata branch March 22, 2023 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants