Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding opensea security provider image for What's New #18292

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Mar 22, 2023

Had to add back the image that was reverted in #17968

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 changed the title adding opensea security provider image Re-adding opensea security provider image for What's New Mar 22, 2023
@vthomas13 vthomas13 marked this pull request as ready for review March 22, 2023 20:50
@vthomas13 vthomas13 requested a review from a team as a code owner March 22, 2023 20:50
@vthomas13 vthomas13 requested a review from hmalik88 March 22, 2023 20:50
@metamaskbot
Copy link
Collaborator

Builds ready [77fa9d1]
Page Load Metrics (1580 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint971761222110
domContentLoaded1427174915787335
load1427174915807436
domInteractive1427174915787335
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@34ba624). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop   #18292   +/-   ##
==========================================
  Coverage           ?   64.49%           
==========================================
  Files              ?      910           
  Lines              ?    35281           
  Branches           ?     9037           
==========================================
  Hits               ?    22751           
  Misses             ?    12530           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vthomas13 vthomas13 merged commit e424deb into develop Mar 23, 2023
@vthomas13 vthomas13 deleted the whats-new-opensea-image branch March 23, 2023 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants