Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing deprecated constants in Popover folder #19245

Merged

Conversation

dhruvv173
Copy link
Contributor

Explanation

Screenshots/Screencaps

Before

before.mp4

After

after.mp4

Manual Testing Steps

jest tests

image

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 21, 2023 12:40
@dhruvv173 dhruvv173 requested a review from OGPoyraz May 21, 2023 12:40
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #19245 (09301e8) into develop (9d38e53) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19245      +/-   ##
===========================================
- Coverage    70.30%   70.30%   -0.01%     
===========================================
  Files          960      960              
  Lines        36689    36689              
  Branches      9543     9543              
===========================================
- Hits         25793    25791       -2     
- Misses       10896    10898       +2     
Impacted Files Coverage Δ
...i/components/component-library/popover/popover.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@dhruvv173
Copy link
Contributor Author

hey @georgewrmarshall, could you please review this PR?
Thanks!

@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for OGPoyraz May 22, 2023 08:06
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great PR description. Thanks for your contribution @dhruvv173 💯

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 22, 2023
@georgewrmarshall georgewrmarshall merged commit cdaa21b into MetaMask:develop May 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
@dhruvv173 dhruvv173 deleted the Replacing-deprecated-constants branch July 25, 2023 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants