Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: concurrently@^7.6.0->^8.2.1 #20677

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Aug 31, 2023

Explanation

https://github.com/open-cli-tools/concurrently/releases/tag/v8.0.0

What's Changed

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Aug 31, 2023
@legobeat legobeat marked this pull request as ready for review August 31, 2023 11:26
@legobeat legobeat requested a review from a team as a code owner August 31, 2023 11:26
@socket-security
Copy link

socket-security bot commented Aug 31, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/concurrently@8.2.2 environment, filesystem Transitive: shell +16 11.8 MB gustavohenke

🚮 Removed packages: npm/concurrently@7.6.0

View full report↗︎

@legobeat
Copy link
Contributor Author

failing e2e test must be flaky unrelated.

brad-decker
brad-decker previously approved these changes Aug 31, 2023
@legobeat legobeat force-pushed the devdeps-concurrently-8 branch 3 times, most recently from 11d5bb1 to 67d8a5a Compare September 1, 2023 22:03
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93a950f) 68.27% compared to head (eabee6a) 68.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20677      +/-   ##
===========================================
- Coverage    68.27%   68.27%   -0.00%     
===========================================
  Files         1087     1087              
  Lines        42770    42770              
  Branches     11371    11371              
===========================================
- Hits         29201    29200       -1     
- Misses       13569    13570       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DDDDDanica
DDDDDanica previously approved these changes Oct 17, 2023
@legobeat legobeat force-pushed the devdeps-concurrently-8 branch 6 times, most recently from e1e2de9 to 4bcb91a Compare November 1, 2023 12:17
Copy link

socket-security bot commented Nov 9, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat requested review from a team and removed request for a team January 22, 2024 11:14
@legobeat legobeat force-pushed the devdeps-concurrently-8 branch 2 times, most recently from 0f717bc to ff25caa Compare January 26, 2024 13:20
@legobeat legobeat force-pushed the devdeps-concurrently-8 branch 6 times, most recently from 8b1620b to 1e40bf8 Compare February 1, 2024 16:23
@legobeat legobeat requested a review from a team February 1, 2024 18:45
@legobeat legobeat force-pushed the devdeps-concurrently-8 branch 2 times, most recently from 4276b91 to 575c34e Compare February 2, 2024 12:51
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 9efad46 into MetaMask:develop Feb 8, 2024
67 of 68 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@legobeat legobeat deleted the devdeps-concurrently-8 branch February 8, 2024 17:07
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 17, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.11.0 on PR, as PR was added to branch 11.11.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants