Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update speed up transaction.csv #20883

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Update speed up transaction.csv #20883

merged 6 commits into from
Sep 25, 2023

Conversation

benjisclowder
Copy link
Contributor

Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item.

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item.
@benjisclowder benjisclowder added area-documentation Issues relating to documentation, in the codebase and off. team-extension-platform labels Sep 14, 2023
@benjisclowder benjisclowder requested a review from a team as a code owner September 14, 2023 11:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (df327a4) 68.25% compared to head (53bb24a) 68.25%.

❗ Current head 53bb24a differs from pull request most recent head 2fc4280. Consider uploading reports for the commit 2fc4280 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20883      +/-   ##
===========================================
- Coverage    68.25%   68.25%   -0.00%     
===========================================
  Files         1006     1006              
  Lines        40190    40184       -6     
  Branches     10744    10742       -2     
===========================================
- Hits         27430    27424       -6     
  Misses       12760    12760              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [18316a7]
Page Load Metrics (1627 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint115173143157
domContentLoaded1419180116279345
load1419180116279345
domInteractive1419180116279345
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f39738f]
Page Load Metrics (1507 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint109166128136
domContentLoaded1352162815077335
load1352162815077335
domInteractive1352162815077335
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [53bb24a]
Page Load Metrics (1937 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1352571733115
domContentLoaded14992336193619192
load14992337193719192
domInteractive14992336193619192
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [2fc4280]
Page Load Metrics (1522 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint116161134115
domContentLoaded1427164915225727
load1427165015225727
domInteractive1427164915225727
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@brad-decker
Copy link
Contributor

:shipit:

@benjisclowder benjisclowder merged commit 4ee7157 into develop Sep 25, 2023
63 checks passed
@benjisclowder benjisclowder deleted the benjisclowder-patch-6 branch September 25, 2023 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants