-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CORS issues in FireFox #2138
Conversation
This isnt really a CORS issue is it? CORS headers are (afaik) correctly set in infura responses. @Zanibas will need to add the conversion rate api as well i wonder if you can do second level wildcard: |
See Host permissions https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/permissions You are right about wildcard, will update asap. Also, will add |
so for:
However CORS headers should be set correctly by infura |
reaching out to infura team... |
@tmashuang did you verify its working correctly after infura's changes? |
The main issue on Firefox that this solves is viewing tokens. Even after the Infura headers view tokens is still not visible in Firefox. I am in favour of these additions for Firefox. |
@tmashuang @kumavis any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes Firefox failing fetch resource #1779
Fixes #1779
Looks like Firefox requires adding all HTTP addresses to
manifest.json
, so I added addresses forrinkeby
,kovan
,ropsten
andmainnet
.Verified on:
https://dapp.acebusters.com
http://registrar.ens.domains/