-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assets controllers to version 22 - OpenSea V2 #22324
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22324 +/- ##
========================================
Coverage 67.87% 67.87%
========================================
Files 1068 1068
Lines 41301 41301
Branches 11079 11080 +1
========================================
Hits 28030 28030
Misses 13271 13271 ☔ View full report in Codecov by Sentry. |
Hey @bergeron i want to ask if you will update the usage of v1 api in MM repo as well? |
Builds ready [5504808]
Page Load Metrics (1283 ± 128 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Good flag. Looking into this endpoint, but I suspect this V1 might be an internal versioning scheme and not OpenSea's V1. |
Missing release label release-11.7.3 on PR. Adding release label release-11.7.3 on PR and removing other release labels(release-11.9.0), as PR was cherry-picked in branch 11.7.3. |
Description
Updates the assets controllers package to version 22.0.0. This brings in PR 3654 to migrate from OpenSea V1 to V2 API.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1841
Manual testing steps
Screenshots/Recordings
No visible differences
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist