Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump metamask/gas-fee-controller to v15.1.1 #24333

Closed
wants to merge 2 commits into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 1, 2024

Description

This PR bumps the gas-fee-controller to the latest version.

The changes between the previous version and the latest are:

[15.1.1]

Changed*

  • Bump @metamask/polling-controller to ^6.0.2 (#4234)

Removed

  • Remove fee history fallback in favour of eth_gasPrice call (#4210)

[15.1.0]

Added

  • Add nonRPCGasFeeApisDisabled property to the gas fee controller, allowing the user to specify that they want to prevent network request to gas estimate services, and only want gas estimates to be based on rpc requests (eth_feeHistory and eth_gasPrice) to the provider. (#4094)

Fixed

  • Fix GasFeeController incorrectly setting globally selected state, so that state is only updated if the gasFeeEstimate fetched is for the currently selected network (#4214)

Open in GitHub Codespaces

Related issues

Part of: https://github.com/MetaMask/MetaMask-planning/issues/2070

Manual testing steps

This is mostly not testable right now. I will add testing steps after some functionality has been added to another PR. Same goes for automated tests. Some things that can be tested:

  • Gas related functionality should continue to work unchanged
  • Go to the confirmation screen for any transaction on any EIP-1559 network. If developer tools in the background are opened to the network tab, and calls to the /suggestedGasFees api are disabled, then you should see requests to a json rpc api with the method eth_gasPrice

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested a review from a team as a code owner May 1, 2024 18:08
Copy link
Contributor

github-actions bot commented May 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 1, 2024
jiexi
jiexi previously approved these changes May 1, 2024
@legobeat
Copy link
Contributor

legobeat commented May 1, 2024

@metamaskbot update-policies

vthomas13
vthomas13 previously approved these changes May 1, 2024
@@ -5874,6 +5895,23 @@ __metadata:
languageName: node
linkType: hard

"@metamask/polling-controller@npm:^6.0.2":
Copy link
Contributor

@legobeat legobeat May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The old version @metamask/polling-controller is still used by @metamask/assets-controllers and @metamask/smart-transactoions-controller after this.

I guess they should also be updated (separately) to get the same fixes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this needs yarn deduplicate to dedupe with existing @metamask/polling-controller@6.0.1.

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/78538/workflows/68a63caf-d89e-4bf1-b1c0-ef1ad9665cc9/jobs/2738624

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot dismissed stale reviews from vthomas13 and jiexi via 3a6ca17 May 1, 2024 18:34
@danjm danjm requested review from a team as code owners May 1, 2024 18:34
@legobeat legobeat mentioned this pull request May 2, 2024
7 tasks
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legobeat
Copy link
Contributor

legobeat commented May 3, 2024

I guess this is waiting for MetaMask/core#4245 and a release of v15.1.2?

@danjm
Copy link
Contributor Author

danjm commented May 21, 2024

this was replaced by #24520

@danjm danjm closed this May 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
@legobeat legobeat deleted the bump-gas-fee-controller branch May 21, 2024 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants