-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump metamask/gas-fee-controller to v15.1.1 #24333
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@metamaskbot update-policies |
@@ -5874,6 +5895,23 @@ __metadata: | |||
languageName: node | |||
linkType: hard | |||
|
|||
"@metamask/polling-controller@npm:^6.0.2": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: The old version @metamask/polling-controller
is still used by @metamask/assets-controllers
and @metamask/smart-transactoions-controller
after this.
I guess they should also be updated (separately) to get the same fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this needs yarn deduplicate
to dedupe with existing @metamask/polling-controller@6.0.1
.
Policies updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a yarn deduplicate
.
https://github.com/MetaMask/metamask-extension/pull/24333/files#r1586616380
I guess this is waiting for MetaMask/core#4245 and a release of v15.1.2? |
this was replaced by #24520 |
Description
This PR bumps the gas-fee-controller to the latest version.
The changes between the previous version and the latest are:
[15.1.1]
Changed*
@metamask/polling-controller
to^6.0.2
(#4234)Removed
eth_gasPrice
call (#4210)[15.1.0]
Added
Fixed
Related issues
Part of: https://github.com/MetaMask/MetaMask-planning/issues/2070
Manual testing steps
This is mostly not testable right now. I will add testing steps after some functionality has been added to another PR. Same goes for automated tests. Some things that can be tested:
eth_gasPrice
Pre-merge author checklist
Pre-merge reviewer checklist