-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Artifact screenshots per open tab #25453
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25453 +/- ##
========================================
Coverage 64.91% 64.91%
========================================
Files 1390 1390
Lines 55155 55155
Branches 14493 14493
========================================
Hits 35803 35803
Misses 19352 19352 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
awesome work 🔥 |
35b9d95
to
ab59709
Compare
Builds ready [ab59709]
Page Load Metrics (42 ± 2 ms)
Bundle size diffs
|
Description
Currently artifacts only capture a screenshot of one tab (even if it's not relevant or helpful).This PR attempts to catch this case and iterate over every open tab to take a screenshot if there's more than one tab open at the time of test failure.
Related issues
Fixes: N/A
Manual testing steps
throw new Error('e')
statement to any test to force it to failScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist