Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show current network if domains are undefined #25960

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

NidhiKJha
Copy link
Member

If Experimental settings Select Networks for each site is off, the domains are undefined. In this case, the fallback network should be the current network.

Related issues

Fixes: #25887

Manual testing steps

  1. Connect MetaMask to Dapp
  2. Go to Permissions, check the logo of network is specific to connected network
  3. Turn the experimental setting off, Go back to all permissions page. Now the network logo should be same as globally selected network for all the dapps

Screenshots/Recordings

Before

Screenshot 2024-07-19 at 12 06 29 AM

After

Screen.Recording.2024-07-19.at.12.07.35.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner July 18, 2024 23:08
@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 18, 2024
bergeron
bergeron previously approved these changes Jul 18, 2024
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-ux labels Jul 19, 2024
Copy link

sonarcloud bot commented Jul 19, 2024

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (e562224) to head (2b9f4ed).

Files Patch % Lines
ui/selectors/selectors.js 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25960      +/-   ##
===========================================
- Coverage    69.70%   69.70%   -0.00%     
===========================================
  Files         1400     1400              
  Lines        49464    49467       +3     
  Branches     13687    13690       +3     
===========================================
+ Hits         34478    34479       +1     
- Misses       14986    14988       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2b9f4ed]
Page Load Metrics (66 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6912295189
domContentLoaded96230189
load399266189
domInteractive96129189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 130 Bytes (0.00%)

@NidhiKJha NidhiKJha merged commit 3454333 into develop Jul 19, 2024
82 of 83 checks passed
@NidhiKJha NidhiKJha deleted the name-fallback branch July 19, 2024 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RPC - MM breaks with error Message: Cannot read properties of undefined (reading 'rpcPrefs')
5 participants