-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show current network if domains are undefined #25960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Jul 18, 2024
bergeron
previously approved these changes
Jul 18, 2024
bergeron
approved these changes
Jul 19, 2024
metamaskbot
added
INVALID-PR-TEMPLATE
PR's body doesn't match template
team-wallet-ux
labels
Jul 19, 2024
Quality Gate passedIssues Measures |
salimtb
approved these changes
Jul 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25960 +/- ##
===========================================
- Coverage 69.70% 69.70% -0.00%
===========================================
Files 1400 1400
Lines 49464 49467 +3
Branches 13687 13690 +3
===========================================
+ Hits 34478 34479 +1
- Misses 14986 14988 +2 ☔ View full report in Codecov by Sentry. |
Builds ready [2b9f4ed]
Page Load Metrics (66 ± 9 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.3.0
Issue or pull request that will be included in release 12.3.0
label
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.3.0
Issue or pull request that will be included in release 12.3.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Experimental settings
Select Networks for each site
is off, the domains are undefined. In this case, the fallback network should be the current network.Related issues
Fixes: #25887
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-07-19.at.12.07.35.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist