Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump test dapp 8.9.0 #26008

Closed
wants to merge 1 commit into from
Closed

chore: bump test dapp 8.9.0 #26008

wants to merge 1 commit into from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Jul 22, 2024

Description

This PR updates the test-dapp package used in our e2e tests to the latest version.
This will contribute into fixing an area of flakiness introduced by the WalletConnect PR, which was missing await in a couple of places, generating a race condition, which is now fixed in the latest version of the test dapp.

Open in GitHub Codespaces

Related issues

Fixes: #26009

Manual testing steps

  1. Check ci, all tests should continue to work

Screenshots/Recordings

See example of the test dapp race condition, which makes a signatures test fail due to the wallet connect error and the popup never opens:

race-condition-test-dapp.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner July 22, 2024 14:44
@seaona seaona self-assigned this Jul 22, 2024
@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Jul 22, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/test-dapp@8.9.0 None 0 17.1 MB gudahtt

🚮 Removed packages: npm/@metamask/test-dapp@8.4.0

View full report↗︎

Copy link

sonarcloud bot commented Jul 22, 2024

@seaona seaona marked this pull request as draft July 22, 2024 14:59
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 20, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests stale issues and PRs marked as stale team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: test dapp flakiness due to race condition with wallet connect provider
1 participant