-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🏷️ update the text in the popup to enable notifications #26026
fix: 🏷️ update the text in the popup to enable notifications #26026
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Updated the notification popup text to provide clearer instructions on enabling and disabling notifications.
- Modified
app/_locales/en/messages.json
to direct users to the 'notifications settings' instead of 'Settings > Notifications'. - Improved user guidance to reduce confusion regarding notification settings.
- No potential security issues or logical errors introduced by this change.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@@ -6231,7 +6231,7 @@ | |||
"message": "To use wallet notifications, we use a profile to sync some settings across your devices. $1" | |||
}, | |||
"turnOnMetamaskNotificationsMessageThird": { | |||
"message": "You can turn off notifications at any time in $1" | |||
"message": "You can turn off notifications at any time in the $1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit - you can ignore), maybe a description might be handy to inform what the $1
is used for. Realistically we will be re-working this modal in the very-near future to add the notification settings page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Updated the notification popup text to provide clearer instructions on enabling and disabling notifications, and improved block explorer URL handling.
- Locale Updates: Modified multiple locale files (e.g.,
app/_locales/en/messages.json
,app/_locales/de/messages.json
) to correct notification settings instructions. - Block Explorer Button: Updated
ui/components/multichain/notification-detail-block-explorer-button/notification-detail-block-explorer-button.tsx
to useblockExplorerConfig
for dynamic button text. - New Constants: Added
ui/helpers/constants/metamask-notifications/metamask-notifications.ts
to map blockchain networks to block explorers. - Utility Enhancements: Updated
ui/helpers/utils/notification.util.ts
to improve block explorer URL handling and added a type guard function.
18 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [0c6e21e]
Page Load Metrics (254 ± 259 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR fixes the reported bug: #25994. The PR changes the text to inform the user about the option to disable notifications from the notifications settings page (see images). The ability to enable/disable notifications directly from the general settings is expected to be implemented in future releases.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist