chore: bump assets-controllers to v37 #26984

sahar-fehri · 2024-09-09T09:16:05Z

Description

Bump assets-controllers to v37

Related issues

Fixes:
Related: https://github.com/MetaMask/core/blob/main/packages/assets-controllers/CHANGELOG.md#3700

Manual testing steps

Go to NFTs tab, make sure you are able to see your NFTs and NFT details.
Use Test-dapp to watch-NFTs and make sure you are able to add your NFTs.
Make sure token detection is working

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-09T09:16:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-09-09T09:17:04Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/assets-controllers@37.0.0	None	`0`	1.73 MB	metamaskbot
npm/@metamask/polling-controller@9.0.1	None	`0`	138 kB	metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@36.0.0, npm/@metamask/polling-controller@9.0.0, npm/@metamask/preferences-controller@13.0.0

View full report↗︎

sahar-fehri · 2024-09-09T09:44:31Z

@metamaskbot update-policies

metamaskbot · 2024-09-09T09:53:56Z

Policies updated

metamaskbot · 2024-09-09T18:47:02Z

Builds ready [e1b952e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1743 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1462	2168	1746	224	107
		domContentLoaded	1455	2155	1729	220	106
		load	1463	2171	1743	223	107
		domInteractive	17	178	42	39	19

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.15 KiB (-0.03%)
ui: 3.74 KiB (0.05%)
common: 3.49 KiB (0.04%)

codecov · 2024-09-09T21:03:45Z

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (c4c8fd7) to head (82b3271).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
ui/components/ui/identicon/identicon.component.js	84.62%	2 Missing ⚠️
...ichain/pages/send/components/recipient-content.tsx	66.67%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26984      +/-   ##
===========================================
+ Coverage    70.03%   70.12%   +0.09%     
===========================================
  Files         1443     1445       +2     
  Lines        50169    50229      +60     
  Branches     14041    14053      +12     
===========================================
+ Hits         35131    35220      +89     
+ Misses       15038    15009      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-09T21:15:25Z

Builds ready [30e7e36]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1788 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	227	2434	1637	526	252
		domContentLoaded	1506	2428	1771	239	115
		load	1510	2433	1788	246	118
		domInteractive	12	157	39	30	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.15 KiB (-0.03%)
ui: 3.74 KiB (0.05%)
common: 3.49 KiB (0.04%)

ui/helpers/utils/util.js

metamaskbot · 2024-09-10T08:51:10Z

Builds ready [8d7d88e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1660 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	235	2017	1513	407	196
		domContentLoaded	1472	1992	1630	146	70
		load	1481	1998	1660	148	71
		domInteractive	20	99	43	24	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.15 KiB (-0.03%)
ui: 3.74 KiB (0.05%)
common: 3.46 KiB (0.04%)

ui/components/app/assets/nfts/nfts-items/nfts-items.js

yarn.lock

metamaskbot · 2024-09-10T09:59:07Z

Builds ready [6ca9c85]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1914 ± 166 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	240	2938	1654	670	322
		domContentLoaded	1487	2912	1889	344	165
		load	1495	2917	1914	345	166
		domInteractive	13	72	40	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.15 KiB (-0.03%)
ui: 3.74 KiB (0.05%)
common: 3.46 KiB (0.04%)

ui/components/app/assets/nfts/nft-details/nft-details.tsx

metamaskbot · 2024-09-17T17:27:35Z

Builds ready [96b56f4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1768 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1577	2077	1766	120	58
		domContentLoaded	1569	2027	1736	112	54
		load	1578	2079	1768	121	58
		domInteractive	19	155	42	30	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.76 KiB (-0.05%)
ui: 3.78 KiB (0.05%)
common: 3.42 KiB (0.04%)

metamaskbot · 2024-09-18T08:38:21Z

Builds ready [4b7eeb6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1957 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	375	2411	1894	400	192
		domContentLoaded	1703	2388	1927	203	97
		load	1715	2395	1957	202	97
		domInteractive	15	83	40	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.76 KiB (-0.05%)
ui: 3.78 KiB (0.05%)
common: 3.42 KiB (0.04%)

OGPoyraz

Confirmation changes LGTM

sonarcloud · 2024-09-18T15:22:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-18T15:52:46Z

Builds ready [82b3271]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1901 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1602	2222	1900	190	91
		domContentLoaded	1594	2210	1859	189	91
		load	1602	2226	1901	191	92
		domInteractive	15	106	43	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.76 KiB (-0.05%)
ui: 3.78 KiB (0.05%)
common: 3.42 KiB (0.04%)

metamaskbot · 2024-09-29T17:09:43Z

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

chore: bump assets-controllers to v37

1b874ef

github-actions bot added the team-assets label Sep 9, 2024

Update LavaMoat policies

8605106

fix: make async getAssetImageURL

e1b952e

sahar-fehri added 3 commits September 9, 2024 21:11

fix: unit test

e6a2835

fix: unit test

b04727b

fix: lint

30e7e36

sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Sep 9, 2024

sahar-fehri marked this pull request as ready for review September 9, 2024 21:57

sahar-fehri requested review from a team as code owners September 9, 2024 21:57

sahar-fehri commented Sep 10, 2024

View reviewed changes

ui/helpers/utils/util.js Show resolved Hide resolved

sahar-fehri added 2 commits September 10, 2024 10:13

fix: rm log

8aac12e

fix: rename fct

8d7d88e

legobeat reviewed Sep 10, 2024

View reviewed changes

ui/components/app/assets/nfts/nfts-items/nfts-items.js Outdated Show resolved Hide resolved

Merge branch 'develop' into feat/upgrade-assets-controllers-to-v37

6ca9c85

legobeat reviewed Sep 10, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

sahar-fehri requested a review from legobeat September 10, 2024 12:51

gambinish reviewed Sep 10, 2024

View reviewed changes

ui/components/app/assets/nfts/nft-details/nft-details.tsx Outdated Show resolved Hide resolved

gambinish previously approved these changes Sep 17, 2024

View reviewed changes

vinnyhoward previously approved these changes Sep 17, 2024

View reviewed changes

fix: rm not needed nftController callbacks

96b56f4

sahar-fehri dismissed stale reviews from vinnyhoward and gambinish via 96b56f4 September 17, 2024 16:40

gambinish previously approved these changes Sep 17, 2024

View reviewed changes

vinnyhoward previously approved these changes Sep 17, 2024

View reviewed changes

bergeron previously approved these changes Sep 17, 2024

View reviewed changes

salimtb previously approved these changes Sep 17, 2024

View reviewed changes

fix: merge conflicts

4b7eeb6

sahar-fehri dismissed stale reviews from salimtb, bergeron, vinnyhoward, and gambinish via 4b7eeb6 September 18, 2024 08:04

salimtb approved these changes Sep 18, 2024

View reviewed changes

OGPoyraz approved these changes Sep 18, 2024

View reviewed changes

bergeron approved these changes Sep 18, 2024

View reviewed changes

Merge branch 'develop' into feat/upgrade-assets-controllers-to-v37

82b3271

vinnyhoward approved these changes Sep 18, 2024

View reviewed changes

sahar-fehri merged commit 97dce9f into develop Sep 18, 2024
78 checks passed

sahar-fehri deleted the feat/upgrade-assets-controllers-to-v37 branch September 18, 2024 16:09

github-actions bot locked and limited conversation to collaborators Sep 18, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 18, 2024

metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump assets-controllers to v37 #26984

chore: bump assets-controllers to v37 #26984

sahar-fehri commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024

socket-security bot commented Sep 9, 2024 •

edited

Loading

sahar-fehri commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

codecov bot commented Sep 9, 2024 •

edited

Loading

metamaskbot commented Sep 9, 2024

metamaskbot commented Sep 10, 2024

metamaskbot commented Sep 10, 2024

metamaskbot commented Sep 17, 2024

metamaskbot commented Sep 18, 2024

OGPoyraz left a comment

sonarcloud bot commented Sep 18, 2024

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 29, 2024

chore: bump assets-controllers to v37 #26984

chore: bump assets-controllers to v37 #26984

Conversation

sahar-fehri commented Sep 9, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 9, 2024

socket-security bot commented Sep 9, 2024 • edited Loading

sahar-fehri commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

codecov bot commented Sep 9, 2024 • edited Loading

Codecov Report

metamaskbot commented Sep 9, 2024

metamaskbot commented Sep 10, 2024

metamaskbot commented Sep 10, 2024

metamaskbot commented Sep 17, 2024

metamaskbot commented Sep 18, 2024

OGPoyraz left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 18, 2024

Quality Gate passed

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 29, 2024

sahar-fehri commented Sep 9, 2024 •

edited

Loading

socket-security bot commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 9, 2024 •

edited

Loading