fix: fix api spec multichain bump issues #27669
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@open-rpc/schema-utils-js@2.0.3 |
|
❌ API Spec Test Failed. View the report here. |
|
❌ API Spec Test Failed. View the report here. |
|
❌ API Spec Test Failed. View the report here. |
…text around multichain
|
❌ API Spec Test Failed. View the report here. |
| @@ -74,7 +74,7 @@ export class MultichainAuthorizationConfirmationErrors implements Rule { | |||
| if (isMethodAllowed) { | |||
| if (method.errors) { | |||
| method.errors.forEach((err) => { | |||
| const unsupportedErrorCodes = [5000, 5300, 5301]; | |||
| const unsupportedErrorCodes = [5000, 5100, 5101, 5102, 5300, 5301]; | |||
There was a problem hiding this comment.
we should update the spec to remove these errors. Or if we are adding them as warnings we should be able to write a new Rule to test for that based on the errors in the spec.
| // 'wallet_getSession', | ||
| // 'wallet_revokeSession' |
There was a problem hiding this comment.
these no longer throw now. may require API specs update though
|
Description
Remove unused error codes and skip wallet_getSession and revokeSession for now. bump schema-utils-js with a couple bug fixes. Fixed parsing ordering.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist