-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate empty key #4513
Validate empty key #4513
Conversation
Previously importing an empty string would result in a new empty Keyring object to be constructed, with no notification to the user. Now we render a clear error explaining the mistake.
I think we need strong validation, like making sure the private key is actually valid |
However, they no longer seem to work. I'm unclear why this test is failing. The private key being provided should be valid.
Added a commit that includes much more strong private key importing validations, but for some reason they fail. Will have to revisit at some point. Should be easy for someone else to pick up, if they wanted to finish this out. |
… ValidateEmptyKey
|
I would approve this, but I can't b/c I opened the PR. Thanks for clarifying the assert.fails/async issue. |
BY THE POWER VESTED IN ME, I DECLARE YOU APPROVED. YOU MAY NOW MERGE WITH THE BASE. |
Previously importing an empty string would result in a new empty Keyring
object to be constructed, with no notification to the user.
Now we render a clear error explaining the mistake.
This would not result in any bad accounts, just a memory leak.