Cast arguments for new Bignumbers() to string. #5060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due an unexpected issue in our current version of bignumber.js (MikeMcl/bignumber.js#148),
new Bignumber(x)
where x's significant digits were greater than 15 and x is not a string were throwing an error.It seems that all our instances of
new Bignumber(x)
that were getting hit by numbers with that many significant digits were already casting args to strings, except for the new approve screen.This PR updates all cases of
new Bignumber(x)
where x was not being converted to a string.For a before and after test. Before:
develop
, switch to mainnet and go to https://dai.makerdao.com/MKRWipe/Shut
on the right side of the screenAfter: