Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill gasPrice for retry attempts with either the recommended gasprice or a %10 bump #5786

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

frankiebee
Copy link
Contributor

@frankiebee frankiebee commented Nov 20, 2018

fixes #5779

this will set the gasPrice on the txPrams to either be the recommended gas price or the %10 bump of the original which ever is higher

@metamaskbot
Copy link
Collaborator

Builds ready [05203c4]: mascara, chrome, firefox, edge, opera

@danjm
Copy link
Contributor

danjm commented Nov 20, 2018

Do we want to force the user to use our recommended gas price on retry?

What do you think about the following approach?

  • if a user is ever setting the gas price to below our recommended minimum, we should show a warning
  • if a user is retrying a transaction that had a gas price of 0, then we:
    • autofill gas price with our recommended gas price
    • still allow the user to set it as low as they wish
    • prevent them from sending a retry transaction with 0 gas price, and show an error message in that case
  • if the original tx price was greater than 0, continue to force retries to be priced at 110% of the original tx price

@frankiebee frankiebee added the DO-NOT-MERGE Pull requests that should not be merged label Nov 21, 2018
@frankiebee
Copy link
Contributor Author

@danjm this dosent force the user into it this is the method is still before the approval so they have a chance to change it but i can just do an autofill only for 0 thats a good idea too... dont want to rush merge this till the ui is also on the same page

@frankiebee frankiebee removed the DO-NOT-MERGE Pull requests that should not be merged label Nov 26, 2018
@frankiebee frankiebee merged commit 8198ec9 into develop Nov 26, 2018
@frankiebee frankiebee deleted the retry-txs-autofill-gasPrice branch November 26, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up button should account for current gas prices
3 participants