Loading network screen #5893
Loading network screen #5893
Conversation
danjm
force-pushed
the
loading-network-screen
branch
from
04e411d
to
9b4d61a
Compare
| constructor (props) { | ||
| super(props) | ||
|
|
||
| this.state = { |
There was a problem hiding this comment.
We can move this out of the ctor and onto the class as a property
| import Spinner from '../spinner' | ||
| import Button from '../button' | ||
|
|
||
| class LoadingNetworkScreen extends Component { |
There was a problem hiding this comment.
Can we use PureComponent here?
| } | ||
| } | ||
|
|
||
| LoadingNetworkScreen.propTypes = { |
There was a problem hiding this comment.
Can we can move this into the class a property?
| @@ -0,0 +1,2 @@ | |||
| const LoadingNetworksScreen = require('./loading-network-screen.container') | |||
| module.exports = LoadingNetworksScreen | |||
There was a problem hiding this comment.
Why did you choose to use module.exports over export here?
|
|
||
| } | ||
|
|
||
| module.exports = LoadingNetworkScreen |
There was a problem hiding this comment.
Can we use export default here?
| } | ||
| } | ||
|
|
||
| LoadingNetworkScreen.propTypes = { |
There was a problem hiding this comment.
Let's use static propTypes in the class definition similarly to contextTypes.
| import Spinner from '../spinner' | ||
| import Button from '../button' | ||
|
|
||
| class LoadingNetworkScreen extends Component { |
There was a problem hiding this comment.
Can we extend PureComponent to reduce rendering assuming the props aren't being mutated?
| t: PropTypes.func, | ||
| } | ||
|
|
||
| componentWillMount = () => { |
There was a problem hiding this comment.
Can we use componentDidMount here instead, since componentWillMount will be deprecated in the future?
| showNetworkDropdown() | ||
| }} | ||
| > | ||
| { 'Switch Networks' } |
There was a problem hiding this comment.
Should this and "Try Again" below be translated strings?
| submitText={t('tryAgain')} | ||
| > | ||
| <ModalContent | ||
| description={'Oops! Something went wrong.'} |
There was a problem hiding this comment.
Should this be translated text?
| @@ -40,7 +40,7 @@ export default class TransactionList extends PureComponent { | |||
| shouldShowRetry = transaction => { | |||
| const { transactionToRetry } = this.props | |||
| const { id, submittedTime } = transaction | |||
| return id === transactionToRetry.id && Date.now() - submittedTime > 30000 | |||
| return id === transactionToRetry.id && Date.now() - submittedTime > 3000 | |||
There was a problem hiding this comment.
Should this change be committed? Or was the time reduced to 3 seconds for testing purposes?
ui/app/selectors.js
Outdated
| const { metamask: { provider: { type, nickname, rpcTarget } } } = state | ||
|
|
||
| return nickname || rpcTarget || type | ||
|
|
|
seeing a little funky text display
|
danjm
force-pushed
the
loading-network-screen
branch
from
caa69be
to
6e89fee
Compare
danjm
force-pushed
the
loading-network-screen
branch
from
6e89fee
to
ad1ddc6
Compare
|
@bdresser the translation issue has been fixed
|
|
@alextsg the other translation you pointed out "Oops! Something Went Wrong" has also been fixed |
| @@ -1215,6 +1221,8 @@ | |||
| }, | |||
| "speedUpTransaction": { | |||
| "message": "Speed up this transaction" | |||
| "switchNetworks": { | |||
There was a problem hiding this comment.
This looks like a formatting error?
There was a problem hiding this comment.
I think there should be a closing brace on the line above
danjm
force-pushed
the
loading-network-screen
branch
from
ad1ddc6
to
04cc98d
Compare
fixes #3776
fixes #5609