Centre all notification popups #6271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
centre-notificatons
branch
from
b4af33b
to
08ea819
Compare
danfinlay
requested changes
Mar 8, 2019
| const width = 360 | ||
|
|
||
| const SCREEN_WIDTH = window.screen.width | ||
| const SCREEN_HEIGHT = window.screen.height |
There was a problem hiding this comment.
Since a screen's resolution can be adjusted at run-time, we should maybe re-compute this at popup creation time.
There was a problem hiding this comment.
Good idea! I'll fix this right up.
whymarrh
force-pushed
the
centre-notificatons
branch
2 times, most recently
from
e8db224
to
071c924
Compare
danfinlay
previously approved these changes
Mar 8, 2019
whymarrh
force-pushed
the
centre-notificatons
branch
from
071c924
to
3cdcb8d
Compare
whymarrh
force-pushed
the
centre-notificatons
branch
from
3cdcb8d
to
5bf8a36
Compare
|
@danfinlay I had to rebase this on the latest |
|
cc @cjeria |
kumavis
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6269
This PR centres all the notification popups based on the screen size.
The support for
window.screen.heightandwindow.screen.widthseem good, according to MDN.[1]