Auto logout after specific time #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
previously approved these changes
May 6, 2019
danjm
approved these changes
May 7, 2019
danjm
requested changes
May 7, 2019
There was a problem hiding this comment.
@chikeichan It seems the necessary changes to advanced-tab.container.js have been removed from this PR. For instance, setAutoLogoutTimeLimit is not defined anywhere
wow, let me check on this later today. Thanks for pointing this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple Notes:
In the screen cap, timer is set to respond in seconds instead of minutes for the sake of time
react-idle-timeris fairly actively maintained -> 20+ commits within last 6 months. I think the risk is trivial, but I am open to refactoring into our own idle-timer module.unit test
fix/update integration test