Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian translation #6878

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Persian translation #6878

merged 1 commit into from
Sep 3, 2019

Conversation

ethan0x8
Copy link
Contributor

I've added the Persian translation.

@whymarrh
Copy link
Contributor

Hey @ehsan01, thanks for this! Unfortunately our right-to-left is... er, pending (#6822) and we'll want to land that first to make this the best possible experience.

@whymarrh
Copy link
Contributor

(In the meantime, if you did want to rebase this on the latest develop that'd fix up the test-deps failure. Not required though. 😅)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is fantastic!

Could you add this to the locale index in app/_locales/index.json as well? Otherwise it's impossible for the user to select this locale.

@mapmeld
Copy link
Contributor

mapmeld commented Sep 3, 2019

Hi @ehsan01 ! RTL support is now merged in
If you add "fa": "فارسی" to the languages JSON file, then it can get merged.
There are a few UI changes to translate, but I can send them to you and a friend in Herat to add later

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just went ahead and made that minor change myself, as I'm eager to get at least one RTL locale merged to demonstrate the RTL support. I've also deleted a few messages that were recently removed.

Thanks for the contribution @ehsan01 ! Any further additions to the locale would be greatly appreciated 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants