Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize images only during production build #7194

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Optimize images only during production build #7194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af83bb
Optimize images only during production build
Gudahtt Sep 19, 2019
0e13aa8
Remove unused gulp tasks
Gudahtt Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const manifest = require('./app/manifest.json')
const sass = require('gulp-sass')
const autoprefixer = require('gulp-autoprefixer')
const gulpStylelint = require('gulp-stylelint')
const stylefmt = require('gulp-stylefmt')
const terser = require('gulp-terser-js')
const pify = require('pify')
const rtlcss = require('gulp-rtlcss')
Expand Down Expand Up @@ -357,12 +356,6 @@ gulp.task('lint-scss', function () {
}))
})

gulp.task('fmt-scss', function () {
return gulp.src('ui/app/css/itcss/**/*.scss')
.pipe(stylefmt())
.pipe(gulp.dest('ui/app/css/itcss'))
})

// build js

const buildJsFiles = [
Expand Down Expand Up @@ -454,18 +447,6 @@ gulp.task('zip', gulp.parallel('zip:chrome', 'zip:firefox', 'zip:opera'))

// high level tasks

gulp.task('dev',
gulp.series(
'clean',
'dev:scss',
gulp.parallel(
'dev:extension:js',
'dev:copy',
'dev:reload'
)
)
)

gulp.task('dev:test',
gulp.series(
'clean',
Expand Down Expand Up @@ -514,23 +495,10 @@ gulp.task('build:test',
'build:test:extension:js',
'copy'
),
'optimize:images',
'manifest:testing'
)
)

gulp.task('build:extension',
gulp.series(
'clean',
'build:scss',
gulp.parallel(
'build:extension:js',
'copy'
),
'optimize:images'
)
)

gulp.task('dist',
gulp.series(
'build',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@
"gulp-rtlcss": "^1.4.0",
"gulp-sass": "^4.0.0",
"gulp-sourcemaps": "^2.6.0",
"gulp-stylefmt": "^1.1.0",
"gulp-stylelint": "^7.0.0",
"gulp-terser-js": "^5.0.0",
"gulp-util": "^3.0.7",
Expand Down Expand Up @@ -279,6 +278,7 @@
"source-map-explorer": "^2.0.1",
"static-server": "^2.2.1",
"style-loader": "^0.21.0",
"stylelint": "^9.10.1",
"stylelint-config-standard": "^18.2.0",
"tape": "^4.5.1",
"testem": "^2.16.0",
Expand Down
Loading