Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I#3669 ignore known transactions on first broadcast and continue with normal flow #7328

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

frankiebee
Copy link
Contributor

related to issue #3669

their might be other problems lying in the grass on this one so wont call this a full fix

@metamaskbot
Copy link
Collaborator

Builds ready [4c41138]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankiebee frankiebee merged commit 51e5220 into develop Oct 30, 2019
@frankiebee frankiebee deleted the i#3669known-transactions-on-first-broadcast branch October 30, 2019 21:40
tmashuang pushed a commit that referenced this pull request Nov 4, 2019
… normal flow (#7328)

* transactions - ignore known tx errors

* tests - test ignoreing Transaction Failed: known transaction message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants