Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gas when asset is changed on send screen. #7491

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Update gas when asset is changed on send screen. #7491

merged 3 commits into from
Nov 22, 2019

Conversation

tmashuang
Copy link
Contributor

Fixes #7382

Edge case not accounted for is going from token address -> ETH, but tx in this instance usually don't fail.

@metamaskbot
Copy link
Collaborator

Builds ready [4736e3e]

Gudahtt
Gudahtt approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks reasonable.

@tmashuang tmashuang merged commit eecaa4e into develop Nov 22, 2019
@tmashuang tmashuang deleted the send-gas branch November 22, 2019 19:59
@wjmelements wjmelements mentioned this pull request Nov 22, 2019
Closed
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token transfers using 21000 gas
4 participants
@tmashuang @metamaskbot @whymarrh @Gudahtt