Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing hardware connect error display #7519

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Fixing hardware connect error display #7519

merged 1 commit into from
Nov 23, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 23, 2019

Fixes: #7518

Test plan is defined in the issue.

Problem as the entire error object was being cast as a string, we need to just grab the message prop

whymarrh
whymarrh approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @ryanml!

@whymarrh whymarrh merged commit 878e0e3 into MetaMask:develop Nov 23, 2019
@ryanml ryanml deleted the fix-trezor-error branch November 25, 2019 00:28
Gudahtt pushed a commit that referenced this pull request Dec 5, 2019
@ryanml @Gudahtt
Fixing hardware connect error display (#7519)
e673bfb
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardware connect errors are not being displayed correctly
2 participants
@ryanml @whymarrh