Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent e2e test failure #7873

Merged
merged 1 commit into from
Jan 21, 2020

Commits on Jan 20, 2020

  1. Fix intermittent e2e test failure

    The 'can retype the seed phrase' test would fail sometimes when one of
    the words in the seed phrase was a subset of another word (e.g. 'issue'
    and 'tissue'). This is because the selector used to find the word
    looked for the first element that contained the text, rather than an
    exact match.
    
    To simplify the selector and make it more reliable, test ids were added
    to each seed phrase word. The selector now uses CSS instead of XPath,
    and it only finds exact matches.
    
    A test id was also added to the div containing the shuffled seed words
    to select from, so that the chosen seed words wouldn't be selected
    in place of the real target when the same word appears twice.
    Gudahtt committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    c3bf6b9 View commit details
    Browse the repository at this point in the history