Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bluebird with Node.js API for unhandled rejections #7904

Merged
merged 1 commit into from
Jan 27, 2020

Commits on Jan 26, 2020

  1. Replace bluebird with Node.js API for unhandled rejections

    Unhandled rejections are now caught using built-in Node.js APIs instead
    of with `bluebird`. `bluebird` was added as a production dependency but
    was only used for this purpose. The code responsible for catching
    unhandled rejection in the browser was removed, as this test helper is
    never run in the browser.
    
    Additionally, unhandled rejections are tracked over the course of all
    tests, and result in a non-zero exit code if they remain at the end.
    This was done because it is possible for errors to trigger the
    `uncaughtRejection` event but then still be handled later on. This is
    uncommon, and doesn't seem to happen in our test suite. But if it does
    in the future, it'll be logged but won't result in a non-zero exit
    code.
    Gudahtt committed Jan 26, 2020
    Configuration menu
    Copy the full SHA
    d767afe View commit details
    Browse the repository at this point in the history