Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused getActiveTab selector #8319

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Remove unused getActiveTab selector #8319

merged 1 commit into from
Apr 10, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 9, 2020

This selector was added as part of #7004, but wasn't used by the time it was merged.

@Gudahtt
Remove unused getActiveTab selector
86383d5 
This selector was added as part of #7004, but wasn't used by the time
it was merged.
whymarrh
whymarrh approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [86383d5]
Page Load Metrics (667 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint378644115
domContentLoaded37285666511153
load37485866711153
domInteractive37285566511153

@Gudahtt Gudahtt merged commit 3955a40 into develop Apr 10, 2020
@Gudahtt Gudahtt deleted the remove-unused-get-active-tab-selector branch April 10, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

@jennypollack jennypollack Awaiting requested review from jennypollack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh