Move some errors to analytics instead of sentry (#2529)

* Move some errors to analytics instead of sentry * Add swaps errors * Change to log just as 1 error * Fix typos * Log can't reach branch servers as analytics * Browser: Failed to resolve ENS name for chainId - log as analytics * Update tests Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com>
MetaMask · Apr 30, 2021 · 68c9d6c · 68c9d6c
1 parent 291dc6f
commit 68c9d6c
Show file tree

Hide file tree

Showing 15 changed files with 111 additions and 151 deletions.
diff --git a/app/components/Nav/App/index.js b/app/components/Nav/App/index.js
@@ -28,6 +28,7 @@ import Engine from '../../../core/Engine';
 import Logger from '../../../util/Logger';
 import Branch from 'react-native-branch';
 import AppConstants from '../../../core/AppConstants';
+import { trackErrorAsAnalytics } from '../../../util/analyticsV2';
 
 /**
  * Stack navigator responsible for the onboarding process
@@ -186,7 +187,11 @@ class App extends PureComponent {
 
 	handleDeeplinks = async ({ error, params, uri }) => {
 		if (error) {
-			Logger.error(error, 'Deeplink: Error from Branch');
+			if (error === 'Trouble reaching the Branch servers, please try again shortly.') {
+				trackErrorAsAnalytics('Branch: Trouble reaching servers', error);
+			} else {
+				Logger.error(error, 'Deeplink: Error from Branch');
+			}
 		}
 		const deeplink = params['+non_branch_link'] || uri || null;
 		try {

diff --git a/app/components/UI/AssetOverview/index.js b/app/components/UI/AssetOverview/index.js
@@ -209,7 +209,7 @@ class AssetOverview extends PureComponent {
 		try {
 			await SwapsController.fetchTokenWithCache();
 		} catch (error) {
-			Logger.error(error, 'Swaps: error while fetching tokens with catche in AssetOverview');
+			Logger.error(error, 'Swaps: error while fetching tokens with cache in AssetOverview');
 		}
 	};
 

diff --git a/app/components/UI/ComponentErrorBoundary/index.js b/app/components/UI/ComponentErrorBoundary/index.js
@@ -1,6 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import Logger from '../../../util/Logger';
+import { trackErrorAsAnalytics } from '../../../util/analyticsV2';
 
 class ComponentErrorBoundary extends React.Component {
 	state = { error: null };
@@ -17,7 +18,11 @@ class ComponentErrorBoundary extends React.Component {
 		/**
 		 * Function to be called when there is an error
 		 */
-		onError: PropTypes.func
+		onError: PropTypes.func,
+		/**
+		 * Will not track as an error, but still log to analytics
+		 */
+		dontTrackAsError: PropTypes.bool
 	};
 
 	static getDerivedStateFromError(error) {
@@ -28,6 +33,11 @@ class ComponentErrorBoundary extends React.Component {
 		// eslint-disable-next-line no-unused-expressions
 		this.props.onError?.();
 
+		const { componentLabel, dontTrackAsError } = this.props;
+
+		if (dontTrackAsError) {
+			return trackErrorAsAnalytics(`Component Error Boundary: ${componentLabel}`, error?.message);
+		}
 		Logger.error(error, { View: this.props.componentLabel, ...errorInfo });
 	}
 

diff --git a/app/components/UI/Notification/TransactionNotification/index.js b/app/components/UI/Notification/TransactionNotification/index.js
@@ -94,7 +94,6 @@ function TransactionNotification(props) {
 		accounts,
 		currentNotification,
 		isInBrowserView,
-		navigation,
 		notificationAnimated,
 		onClose,
 		transactions,
@@ -254,7 +253,6 @@ function TransactionNotification(props) {
 							<TransactionDetails
 								transactionObject={tx}
 								transactionDetails={transactionDetails}
-								navigation={navigation}
 								close={onCloseDetails}
 								showSpeedUpModal={onSpeedUpPress}
 								showCancelModal={onCancelPress}
@@ -324,10 +322,6 @@ TransactionNotification.propTypes = {
 	 */
 	accounts: PropTypes.object,
 	/**
-    /* navigation object required to push new views
-    */
-	navigation: PropTypes.object,
-	/**
 	 * An array that represents the user transactions on chain
 	 */
 	transactions: PropTypes.array,

diff --git a/app/components/UI/Swaps/QuotesView.js b/app/components/UI/Swaps/QuotesView.js
@@ -50,8 +50,8 @@ import InfoModal from './components/InfoModal';
 import useModalHandler from '../../Base/hooks/useModalHandler';
 import useBalance from './utils/useBalance';
 import useGasPrice from './utils/useGasPrice';
+import { trackErrorAsAnalytics } from '../../../util/analyticsV2';
 import { decodeApproveData, getTicker } from '../../../util/transactions';
-import Logger from '../../../util/Logger';
 
 const POLLING_INTERVAL = AppConstants.SWAPS.POLLING_INTERVAL;
 const EDIT_MODE_GAS = 'EDIT_MODE_GAS';
@@ -778,7 +778,6 @@ function SwapsQuotesView({
 				slippage,
 				custom_slippage: slippage !== AppConstants.SWAPS.DEFAULT_SLIPPAGE
 			};
-			Logger.error(error?.description, `Swaps: ${error?.key}`);
 			if (error?.key === swapsUtils.SwapsError.QUOTES_EXPIRED_ERROR) {
 				InteractionManager.runAfterInteractions(() => {
 					const parameters = {
@@ -794,6 +793,8 @@ function SwapsQuotesView({
 					Analytics.trackEventWithParameters(ANALYTICS_EVENT_OPTS.NO_QUOTES_AVAILABLE, {});
 					Analytics.trackEventWithParameters(ANALYTICS_EVENT_OPTS.NO_QUOTES_AVAILABLE, parameters, true);
 				});
+			} else {
+				trackErrorAsAnalytics(`Swaps: ${error?.key}`, error?.description);
 			}
 		},
 		[sourceToken, sourceAmount, destinationToken, hasEnoughTokenBalance, slippage]

diff --git a/app/components/UI/TransactionElement/TransactionDetails/__snapshots__/index.test.js.snap b/app/components/UI/TransactionElement/TransactionDetails/__snapshots__/index.test.js.snap
@@ -1,125 +1,37 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`TransactionDetails should render correctly 1`] = `
-<DetailsModalBody>
-  <DetailsModalSection
-    borderBottom={true}
-  >
-    <DetailsModalColumn>
-      <DetailsModalSectionTitle>
-        Status
-      </DetailsModalSectionTitle>
-      <StatusText
-        context="transaction"
-        status="confirmed"
-      />
-    </DetailsModalColumn>
-    <DetailsModalColumn
-      end={true}
-    >
-      <DetailsModalSectionTitle>
-        Date
-      </DetailsModalSectionTitle>
-      <Text
-        black={false}
-        blue={false}
-        bold={false}
-        centered={false}
-        disclaimer={false}
-        green={false}
-        link={false}
-        modal={false}
-        primary={true}
-        red={false}
-        reset={false}
-        right={false}
-        small={true}
-        strikethrough={false}
-        underline={false}
-        upper={false}
-      >
-        [missing "en.date.months.NaN" translation] NaN at NaN:NaNam
-      </Text>
-    </DetailsModalColumn>
-  </DetailsModalSection>
-  <DetailsModalSection
-    borderBottom={false}
-  >
-    <DetailsModalColumn>
-      <DetailsModalSectionTitle>
-        From
-      </DetailsModalSectionTitle>
-      <Text
-        black={false}
-        blue={false}
-        bold={false}
-        centered={false}
-        disclaimer={false}
-        green={false}
-        link={false}
-        modal={false}
-        primary={true}
-        red={false}
-        reset={false}
-        right={false}
-        small={true}
-        strikethrough={false}
-        underline={false}
-        upper={false}
-      >
-        <Connect(EthereumAddress)
-          address="0x0"
-          type="short"
-        />
-      </Text>
-    </DetailsModalColumn>
-    <DetailsModalColumn
-      end={true}
-    >
-      <DetailsModalSectionTitle>
-        To
-      </DetailsModalSectionTitle>
-      <Text
-        black={false}
-        blue={false}
-        bold={false}
-        centered={false}
-        disclaimer={false}
-        green={false}
-        link={false}
-        modal={false}
-        primary={true}
-        red={false}
-        reset={false}
-        right={false}
-        small={true}
-        strikethrough={false}
-        underline={false}
-        upper={false}
-      >
-        <Connect(EthereumAddress)
-          address="0x1"
-          type="short"
-        />
-      </Text>
-    </DetailsModalColumn>
-  </DetailsModalSection>
-  <View
-    style={
-      Array [
-        Object {
-          "marginVertical": 8,
-        },
-        Object {
-          "marginBottom": 24,
-          "marginTop": 12,
-        },
-      ]
+<withNavigation(TransactionDetails)
+  dispatch={[Function]}
+  frequentRpcList={Array []}
+  network={
+    Object {
+      "provider": Object {
+        "rpcTarget": "",
+        "type": "rpc",
+      },
     }
-  >
-    <TransactionSummary
-      gasEstimationReady={true}
-    />
-  </View>
-</DetailsModalBody>
+  }
+  transactionDetails={
+    Object {
+      "renderFrom": "0x0",
+      "renderGas": "21000",
+      "renderGasPrice": "2",
+      "renderTo": "0x1",
+      "renderTotalValue": "2 TKN / 0.001 ETH",
+      "renderTotalValueFiat": "",
+      "renderValue": "2 TKN",
+      "transactionHash": "0x2",
+    }
+  }
+  transactionObject={
+    Object {
+      "networkID": "1",
+      "status": "confirmed",
+      "transaction": Object {
+        "nonce": "",
+      },
+    }
+  }
+/>
 `;
diff --git a/app/components/UI/TransactionElement/TransactionDetails/index.js b/app/components/UI/TransactionElement/TransactionDetails/index.js
@@ -21,6 +21,7 @@ import StatusText from '../../../Base/StatusText';
 import Text from '../../../Base/Text';
 import DetailsModal from '../../../Base/DetailsModal';
 import { RPC } from '../../../../constants/network';
+import { withNavigation } from 'react-navigation';
 
 const styles = StyleSheet.create({
 	viewOnEtherscan: {
@@ -262,4 +263,4 @@ const mapStateToProps = state => ({
 	chainId: state.engine.backgroundState.NetworkController.provider.chainId,
 	frequentRpcList: state.engine.backgroundState.PreferencesController.frequentRpcList
 });
-export default connect(mapStateToProps)(TransactionDetails);
+export default connect(mapStateToProps)(withNavigation(TransactionDetails));
diff --git a/app/components/UI/TransactionElement/TransactionDetails/index.test.js b/app/components/UI/TransactionElement/TransactionDetails/index.test.js
@@ -52,6 +52,6 @@ describe('TransactionDetails', () => {
 				context: { store: mockStore(initialState) }
 			}
 		);
-		expect(wrapper.dive()).toMatchSnapshot();
+		expect(wrapper).toMatchSnapshot();
 	});
 });
diff --git a/app/components/UI/TransactionElement/index.js b/app/components/UI/TransactionElement/index.js
@@ -82,10 +82,6 @@ const transactionIconReceivedFailed = require('../../../images/transaction-icons
 class TransactionElement extends PureComponent {
 	static propTypes = {
 		assetSymbol: PropTypes.string,
-		/**
-		/* navigation object required to push new views
-		*/
-		navigation: PropTypes.object,
 		/**
 		 * Asset object (in this case ERC721 token)
 		 */
@@ -347,7 +343,6 @@ class TransactionElement extends PureComponent {
 						<TransactionDetails
 							transactionObject={tx}
 							transactionDetails={transactionDetails}
-							navigation={this.props.navigation}
 							close={this.onCloseDetailsModal}
 						/>
 					</DetailsModal>

diff --git a/app/components/Views/BrowserTab/index.js b/app/components/Views/BrowserTab/index.js
@@ -66,6 +66,7 @@ import { RPC } from '../../../constants/network';
 import RPCMethods from '../../../core/RPCMethods';
 import AddCustomNetwork from '../../UI/AddCustomNetwork';
 import SwitchCustomNetwork from '../../UI/SwitchCustomNetwork';
+import { trackErrorAsAnalytics } from '../../../util/analyticsV2';
 
 const { HOMEPAGE_URL, USER_AGENT, NOTIFICATION_NAMES } = AppConstants;
 const HOMEPAGE_HOST = 'home.metamask.io';
@@ -913,8 +914,13 @@ export const BrowserTab = props => {
 					ensIgnoreList.push(hostname);
 					return { url: fullUrl, reload: true };
 				}
-				Logger.error(err, 'Failed to resolve ENS name');
-				Alert.alert(strings('browser.error'), strings('browser.failed_to_resolve_ens_name'));
+				if (err?.message?.startsWith('EnsIpfsResolver - no known ens-ipfs registry for chainId')) {
+					trackErrorAsAnalytics('Browser: Failed to resolve ENS name for chainId', err?.message);
+				} else {
+					Logger.error(err, 'Failed to resolve ENS name');
+				}
+
+				Alert.alert(strings('browser.failed_to_resolve_ens_name'), err.message);
 				goBack();
 			}
 		},

diff --git a/app/components/Views/LockScreen/index.js b/app/components/Views/LockScreen/index.js
@@ -8,6 +8,7 @@ import SecureKeychain from '../../../core/SecureKeychain';
 import { baseStyles } from '../../../styles/common';
 import Logger from '../../../util/Logger';
 import { NavigationActions } from 'react-navigation';
+import { trackErrorAsAnalytics } from '../../../util/analyticsV2';
 
 const LOGO_SIZE = 175;
 const styles = StyleSheet.create({
@@ -129,7 +130,11 @@ class LockScreen extends PureComponent {
 			if (this.unlockAttempts <= 3) {
 				this.unlockKeychain();
 			} else {
-				Logger.error(error, { message: 'Lockscreen:maxAttemptsReached', attemptNumber: this.unlockAttempts });
+				trackErrorAsAnalytics(
+					'Lockscreen: Max Attempts Reached',
+					error?.message,
+					`Unlock attempts: ${this.unlockAttempts}`
+				);
 				this.props.navigation.navigate('Login');
 			}
 		}

diff --git a/app/components/Views/Login/index.js b/app/components/Views/Login/index.js
@@ -44,6 +44,7 @@ import { passwordRequirementsMet } from '../../../util/password';
 import ErrorBoundary from '../ErrorBoundary';
 import WarningExistingUserModal from '../../UI/WarningExistingUserModal';
 import Icon from 'react-native-vector-icons/FontAwesome';
+import { trackErrorAsAnalytics } from '../../../util/analyticsV2';
 
 const isTextDelete = text => String(text).toLowerCase() === 'delete';
 const deviceHeight = Device.getDeviceHeight();
@@ -319,6 +320,10 @@ class Login extends PureComponent {
 				error.toLowerCase() === WRONG_PASSWORD_ERROR_ANDROID.toLowerCase()
 			) {
 				this.setState({ loading: false, error: strings('login.invalid_password') });
+
+				trackErrorAsAnalytics('Login: Invalid Password', error);
+
+				return;
 			} else if (error === PASSCODE_NOT_SET_ERROR) {
 				Alert.alert(
 					'Security Alert',

diff --git a/app/components/Views/Settings/SecuritySettings/index.js b/app/components/Views/Settings/SecuritySettings/index.js
@@ -43,6 +43,7 @@ import {
 import CookieManager from '@react-native-community/cookies';
 import Icon from 'react-native-vector-icons/FontAwesome';
 import HintModal from '../../../UI/HintModal';
+import { trackErrorAsAnalytics } from '../../../../util/analyticsV2';
 
 const isIos = Device.isIos();
 
@@ -393,8 +394,10 @@ class Settings extends PureComponent {
 		} catch (e) {
 			if (e.message === 'Invalid password') {
 				Alert.alert(strings('app_settings.invalid_password'), strings('app_settings.invalid_password_message'));
+				trackErrorAsAnalytics('SecuritySettings: Invalid password', e?.message);
+			} else {
+				Logger.error(e, 'SecuritySettings:biometrics');
 			}
-			Logger.error(e, 'SecuritySettings:biometrics');
 			this.setState({ [type]: !enabled, loading: false });
 		}
 	};