Skip to content

Commit

Permalink
Refactor xcodeproj FB_SONARKIT_ENABLED flag to macro
Browse files Browse the repository at this point in the history
Should have been added as an Apple Clang preprocessor macro (not compiler flag) in our RN 0.62.2 upg:
#1586

Refactor in xcodeproj target
- from: Apple Clang - Custom Compiler Flags > Other C Flags
- to: Apple Clang - Preprocessing > Preprocessor Macros

Ref: https://github.com/facebook/react-native/blob/v0.62.0/template/ios/HelloWorld.xcodeproj/project.pbxproj#L500

Nb: rn-tester sticking to "-DFB_SONARKIT_ENABLED=1" for OTHER_CFLAGS and OTHER_SWIFT_FLAGS
  • Loading branch information
leotm committed Oct 14, 2023
1 parent aaba386 commit 83be066
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions ios/MetaMask.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,7 @@
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
"$(inherited)",
"FB_SONARKIT_ENABLED=1",
);
HEADER_SEARCH_PATHS = (
"$(inherited)",
Expand All @@ -1038,10 +1039,7 @@
LLVM_LTO = YES;
MARKETING_VERSION = 7.8.0;
ONLY_ACTIVE_ARCH = YES;
OTHER_CFLAGS = (
"$(inherited)",
"-DFB_SONARKIT_ENABLED=1",
);
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
Expand Down

0 comments on commit 83be066

Please sign in to comment.