Skip to content

Commit

Permalink
chore(runway): cherry-pick fix: Fix/disable flipper for release (#10839)
Browse files Browse the repository at this point in the history
- fix: Fix/disable flipper for release (#10827)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Add NO_FLIPPER to bitrise.yml to disable flipper for release builds

## **Related issues**

Fixes:

## **Manual testing steps**

- Test release build by building for ios QA
- Test e2e build by running e2e smoke

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[ce45b99](ce45b99)

Co-authored-by: Cal Leung <cal.leung@consensys.net>
  • Loading branch information
runway-github[bot] and Cal-L authored Aug 27, 2024
1 parent 93765b4 commit b3eafc0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
4 changes: 4 additions & 0 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,8 @@ workflows:
inputs:
- ipa_path: $BITRISE_APP_STORE_IPA_PATH
build_ios_release:
envs:
- NO_FLIPPER: '1'
before_run:
- code_setup
after_run:
Expand Down Expand Up @@ -1269,6 +1271,8 @@ workflows:
- deploy_path: sourcemaps/ios/index.js.map
title: Deploy Source Map
build_ios_qa:
envs:
- NO_FLIPPER: '1'
before_run:
- code_setup
after_run:
Expand Down
12 changes: 0 additions & 12 deletions scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,6 @@ buildIosRelease(){
# Enable Sentry to auto upload source maps and debug symbols
export SENTRY_DISABLE_AUTO_UPLOAD="false"

# Disable Flipper
export NO_FLIPPER="1"

prebuild_ios

# Replace release.xcconfig with ENV vars
Expand All @@ -319,9 +316,6 @@ buildIosFlaskRelease(){
# remap flask env variables to match what the app expects
remapFlaskEnvVariables

# Disable Flipper
export NO_FLIPPER="1"

prebuild_ios

# Replace release.xcconfig with ENV vars
Expand All @@ -341,9 +335,6 @@ buildIosFlaskRelease(){
}

buildIosReleaseE2E(){
# Disable Flipper
export NO_FLIPPER="1"

prebuild_ios

# Replace release.xcconfig with ENV vars
Expand All @@ -365,9 +356,6 @@ buildIosReleaseE2E(){

buildIosQA(){
remapEnvVariableQA

# Disable Flipper
export NO_FLIPPER="1"

prebuild_ios

Expand Down

0 comments on commit b3eafc0

Please sign in to comment.