Skip to content

Commit

Permalink
fix: OpenSea V1 -> V2 patch (#8155)
Browse files Browse the repository at this point in the history
## **Description**

This is a release version of this PR:
#8135

Migrate to OpenSea V2 API because V1 is being deprecated. Patches this
change from core: MetaMask/core#3654


## **Related issues**

Fixes: MetaMask/MetaMask-planning#1841

## **Manual testing steps**

1. Import a wallet containing NFTs on mainnet
2. Manually import an NFT owner by the wallet, verify it appears
3. Enable NFT autodetection in settings, verify the rest of the NFTs
appear
4. Verify descriptions, collection/token images are correct
5. Send an NFT, verify it works

## **Screenshots/Recordings**

No visible differences between before and after.

### **Before**

<!-- [screenshots/recordings] -->

### **After**



https://github.com/MetaMask/metamask-mobile/assets/3500406/88217ecb-c4e2-473f-a360-c40a8f34d331



## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>
  • Loading branch information
bergeron and chrisleewilcox authored Dec 19, 2023
1 parent 35ccd23 commit c718856
Show file tree
Hide file tree
Showing 3 changed files with 280 additions and 32 deletions.
1 change: 1 addition & 0 deletions app/core/Engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,7 @@ class Engine {
),
getOpenSeaApiKey: () => nftController.openSeaApiKey,
addNft: nftController.addNft.bind(nftController),
getNftApi: nftController.getNftApi.bind(nftController),
getNftState: () => nftController.state,
}),
currencyRateController,
Expand Down
Loading

0 comments on commit c718856

Please sign in to comment.