Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Chore/cherry pick ppom 1.4.8 (#10041) #10045

Merged
merged 1 commit into from
Jun 19, 2024
Merged

chore: Chore/cherry pick ppom 1.4.8 (#10041) #10045

merged 1 commit into from
Jun 19, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jun 19, 2024 •
edited
Loading

Description

Cherry pick for #10041

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners June 19, 2024 21:11
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-confirmations Push issues to confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jun 19, 2024
@Cal-L Cal-L changed the base branch from main to release/7.24.3 June 19, 2024 21:12
@Cal-L Cal-L merged commit 6e38cfb into release/7.24.3 Jun 19, 2024
15 checks passed
@Cal-L Cal-L deleted the chore/cherry-pick-ppom-1.4.8 branch June 19, 2024 21:51
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
@metamaskbot metamaskbot added the release-7.24.3 Issue or pull request that will be included in release 7.24.3 label Jun 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.24.3 on PR, as PR was cherry-picked in branch 7.24.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
release-7.24.3 Issue or pull request that will be included in release 7.24.3 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cal-L @metamaskbot @vinistevam