Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Patch SwapsController to show POL rather than MATIC #10961

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix: Patch SwapsController to show POL rather than MATIC #10961

merged 3 commits into from
Aug 30, 2024
+30 −15

Conversation

gambinish
Copy link
Contributor

Description

Patch MATIC to POL in swaps UI

Related issues

Fixes: #10960

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 30, 2024
sethkfman
sethkfman previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman marked this pull request as ready for review August 30, 2024 21:15
@sethkfman sethkfman requested a review from a team as a code owner August 30, 2024 21:15
@sethkfman sethkfman requested a review from a team as a code owner August 30, 2024 21:23
@socket-security Socket Security
Copy link

socket-security bot commented Aug 30, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/micromatch@4.0.8 None 0 56.6 kB doowb

🚮 Removed packages: npm/micromatch@4.0.5)

View full report↗︎

@sethkfman sethkfman requested a review from a team as a code owner August 30, 2024 21:24
sethkfman
sethkfman approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sethkfman sethkfman merged commit 54d2d19 into release/7.29.1 Aug 30, 2024
25 of 27 checks passed
@sethkfman sethkfman deleted the fix/7.29.1--swaps-matic-pol branch August 30, 2024 21:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gambinish @sethkfman @metamaskbot