Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: initial ramps E2E test to build quote #11086

Merged
merged 19 commits into from
Oct 4, 2024
Merged

test: initial ramps E2E test to build quote #11086

merged 19 commits into from
Oct 4, 2024

Conversation

bkirb
Copy link
Contributor

@bkirb bkirb commented Sep 6, 2024

Description

This is the initial foundation for Ramps Mobile E2E tests. This adds the first basic user flow, which is to login, go through onboarding, select region and payment method, and verify the Build Quote view appears.

Related issues

https://consensyssoftware.atlassian.net/browse/RAMPS-1868
https://consensyssoftware.atlassian.net/browse/RAMPS-1870

Manual testing steps

 PASS  e2e/specs/ramps/onramp.spec.js (43.097 s)
  SmokeRamps Buy Crypto
    ✓ should select Region and Payment Method to see the Build Quote screen (15625 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        43.154 s

Screenshots/Recordings

Untitled.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bkirb bkirb requested a review from jvbriones September 6, 2024 15:59
@bkirb bkirb added the team-ramp issues related to Ramp features label Sep 6, 2024
@bkirb bkirb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 13, 2024
@bkirb bkirb marked this pull request as ready for review September 13, 2024 14:45
@bkirb bkirb requested review from a team as code owners September 13, 2024 14:45
@bkirb bkirb changed the title [Draft] test: initial ramps tests test: initial ramps tests Sep 13, 2024
@bkirb bkirb changed the title test: initial ramps tests test: initial ramps E2E test to build quote Sep 13, 2024

This comment was marked as outdated.

@bkirb bkirb requested a review from wachunei September 13, 2024 18:07
davibroc
davibroc previously approved these changes Sep 17, 2024
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/specs/ramps/onramp.spec.js Outdated Show resolved Hide resolved
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a20232
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/32f12461-0d4e-49f8-9684-4620bad1dce1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick feedback

e2e/pages/Ramps/BuildQuoteView.js Outdated Show resolved Hide resolved
e2e/pages/Ramps/BuildQuoteView.js Outdated Show resolved Hide resolved
@bkirb
Copy link
Contributor Author

bkirb commented Oct 3, 2024

@cortisiko I moved the assertions to the test file, and the test still passes ✅

 PASS  e2e/specs/ramps/onramp.spec.js (137.591 s)
  smokeAssets Buy Crypto
    ✓ should select Region and Payment Method to see the Build Quote screen (15111 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total

@bkirb bkirb requested a review from cortisiko October 3, 2024 02:14
@bkirb bkirb removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 3, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 3, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ✅

Copy link
Contributor

github-actions bot commented Oct 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b106b6d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c17cb87c-1fb6-4375-87a1-7c2e200e1439

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb bkirb added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@bkirb bkirb added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
Copy link

sonarcloud bot commented Oct 4, 2024

@bkirb bkirb added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 98aba82 Oct 4, 2024
37 checks passed
@bkirb bkirb deleted the bkirby/rampsTest branch October 4, 2024 05:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants