Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app event manager and attribution id parameters #11318

Merged
merged 18 commits into from
Sep 23, 2024
Merged

Commits on Sep 19, 2024

  1. feat: attribution id

    abretonc7s committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    97cc53b View commit details
    Browse the repository at this point in the history
  2. feat: reject connection properly (#11314)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    ## **Description**
    
    This PR is an update to the SDK communication protocol that allows the
    following:
    - prevent deleting connection until server confirmation
    - emit rejection event 
    
    ## **Related issues**
    
    - MetaMask/metamask-sdk#1020
    - MetaMask/metamask-sdk#1022
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [x] I’ve followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
    Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [x] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [x] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    abretonc7s committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a678a84 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c19cbff View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    600e556 View commit details
    Browse the repository at this point in the history
  2. feat: app event manager

    abretonc7s committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    058721a View commit details
    Browse the repository at this point in the history
  3. feat: unit test

    abretonc7s committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8ee7bea View commit details
    Browse the repository at this point in the history
  4. feat: cleanup

    abretonc7s committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4920386 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    28b50eb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bfcf67b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fbd505e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    decac43 View commit details
    Browse the repository at this point in the history
  9. feat: ckeanup

    abretonc7s committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d9519aa View commit details
    Browse the repository at this point in the history
  10. feat: cleanup

    abretonc7s committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e27a343 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    689291b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcfa3b1 View commit details
    Browse the repository at this point in the history
  3. feat: cleanup

    abretonc7s committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7545f85 View commit details
    Browse the repository at this point in the history
  4. feat: store init

    abretonc7s committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    dfb0dfd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5366c02 View commit details
    Browse the repository at this point in the history