-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: app event manager and attribution id parameters #11318
Merged
Merged
+336
−0
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97cc53b - Browse repository at this point
Copy the full SHA 97cc53bView commit details -
feat: reject connection properly (#11314)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR is an update to the SDK communication protocol that allows the following: - prevent deleting connection until server confirmation - emit rejection event ## **Related issues** - MetaMask/metamask-sdk#1020 - MetaMask/metamask-sdk#1022 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for a678a84 - Browse repository at this point
Copy the full SHA a678a84View commit details -
Configuration menu - View commit details
-
Copy full SHA for c19cbff - Browse repository at this point
Copy the full SHA c19cbffView commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 600e556 - Browse repository at this point
Copy the full SHA 600e556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 058721a - Browse repository at this point
Copy the full SHA 058721aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ee7bea - Browse repository at this point
Copy the full SHA 8ee7beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4920386 - Browse repository at this point
Copy the full SHA 4920386View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28b50eb - Browse repository at this point
Copy the full SHA 28b50ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfcf67b - Browse repository at this point
Copy the full SHA bfcf67bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbd505e - Browse repository at this point
Copy the full SHA fbd505eView commit details -
Configuration menu - View commit details
-
Copy full SHA for decac43 - Browse repository at this point
Copy the full SHA decac43View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9519aa - Browse repository at this point
Copy the full SHA d9519aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e27a343 - Browse repository at this point
Copy the full SHA e27a343View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 689291b - Browse repository at this point
Copy the full SHA 689291bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcfa3b1 - Browse repository at this point
Copy the full SHA dcfa3b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7545f85 - Browse repository at this point
Copy the full SHA 7545f85View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb0dfd - Browse repository at this point
Copy the full SHA dfb0dfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5366c02 - Browse repository at this point
Copy the full SHA 5366c02View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.