Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Componetize Tokens screen #11471

Merged
merged 39 commits into from
Oct 4, 2024
Merged

chore: Componetize Tokens screen #11471

merged 39 commits into from
Oct 4, 2024
+1,522 −784

Commits on Sep 27, 2024

  1. feat: Add sortAssets utility function

    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0248c74 View commit details
    Browse the repository at this point in the history

  2. chore: Breakup monolithic Tokens/index.tsx into smaller components

    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6a2e8c7 View commit details
    Browse the repository at this point in the history

  3. fix: Correctly handle null check for buyable footer button

    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7a78717 View commit details
    Browse the repository at this point in the history

  4. fix: Tweak boolean logic for rendering footer components

    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    57295ee View commit details
    Browse the repository at this point in the history

  5. chore: Update snapshot

    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d00354f View commit details
    Browse the repository at this point in the history

  6. chore: Type out tokens as TokenI[]

    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    be87f81 View commit details
    Browse the repository at this point in the history

  7. chore: Remove unecessary comments around import statements in Networt… 

    …h component
    @gambinish
    gambinish committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    68c7b2e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a02e139 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    de5bbed View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0fd9ad5 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. chore: Add unit tests to utility file, provide exports from index file

    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    032618c View commit details
    Browse the repository at this point in the history

  2. chore: Rename handleBalance to me more descriptive of what its logic … 

    …is handling
    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a58f1ba View commit details
    Browse the repository at this point in the history

  3. chore: rename Networth to PortfolioBalance for clarity

    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1dd31e3 View commit details
    Browse the repository at this point in the history

  4. chore: Cleanup styles extra whitespace

    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    16ded6a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    52d3d85 View commit details
    Browse the repository at this point in the history

  6. fix: Update snapshot tests

    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dd3ffdf View commit details
    Browse the repository at this point in the history

  7. Merge branch 'chore/componetize-tokens-screen' of github.com:MetaMask… 

    …/metamask-mobile into chore/componetize-tokens-screen
    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    da640bc View commit details
    Browse the repository at this point in the history

  8. fix: Remove unused component

    @gambinish
    gambinish committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ebcbcf6 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    31fad19 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix: StackNavigator derives its own types

    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ab6f500 View commit details
    Browse the repository at this point in the history

  2. Update app/components/UI/Tokens/util/deriveBalanceFromAssetMarketDeta… 

    …ils.test.ts

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    da5ca37 View commit details
    Browse the repository at this point in the history

  3. Update app/components/UI/Tokens/util/deriveBalanceFromAssetMarketDeta… 

    …ils.test.ts

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3fdc1af View commit details
    Browse the repository at this point in the history

  4. Update app/components/UI/Tokens/util/deriveBalanceFromAssetMarketDeta… 

    …ils.test.ts

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    812d219 View commit details
    Browse the repository at this point in the history

  5. Update app/components/UI/Tokens/util/deriveBalanceFromAssetMarketDeta… 

    …ils.test.ts

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7ac0290 View commit details
    Browse the repository at this point in the history

  6. Update app/components/UI/Tokens/util/deriveBalanceFromAssetMarketDeta… 

    …ils.test.ts

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a6412b7 View commit details
    Browse the repository at this point in the history

  7. Update app/components/UI/Tokens/util/sortAssets.test.ts 

    Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    50d278d View commit details
    Browse the repository at this point in the history

  8. Update app/components/UI/Tokens/util/deriveBalanceFromAssetMarketDeta… 

    …ils.test.ts

Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
    @gambinish @NicolasMassart
    gambinish and NicolasMassart authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    58d461a View commit details
    Browse the repository at this point in the history

  9. fix: Type out StackNavigationProp in TokenList

    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    356fc57 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'chore/componetize-tokens-screen' of github.com:MetaMask… 

    …/metamask-mobile into chore/componetize-tokens-screen
    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5c49a2a View commit details
    Browse the repository at this point in the history

  11. fix: Derive StackNavigator props in stake button icon component

    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dcd0335 View commit details
    Browse the repository at this point in the history

  12. fix: Remove Typescript todos

    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8f4d4dd View commit details
    Browse the repository at this point in the history

  13. chore: Extract nested ternary in TokenListItem to an independant if/e… 

    …lse statement
    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    60d72e8 View commit details
    Browse the repository at this point in the history

  14. fix: Remove needless assignment of mainBalance variable in TokenListItem

    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9abfc8e View commit details
    Browse the repository at this point in the history

  15. fix: Lint unused import

    @gambinish
    gambinish committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e30107f View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7f6ce57 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a531043 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    560a0a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b144738 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge branch 'main' into chore/componetize-tokens-screen

    @gambinish
    gambinish authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3e8c909 View commit details
    Browse the repository at this point in the history