Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expandable section for use in confirmation pages #11528

Merged
merged 17 commits into from
Oct 4, 2024
Merged

feat: expandable section for use in confirmation pages #11528

merged 17 commits into from
Oct 4, 2024
+344 −67

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 1, 2024

Description

Adding an expandable section to be used in confirmation pages.

Related issues

Fixes: #11432

Manual testing steps

  1. Run storybook locally
  2. Check confirmations -> expandable section story

Screenshots/Recordings

Screen.Recording.2024-10-01.at.5.51.52.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Oct 1, 2024
@jpuri jpuri requested review from a team as code owners October 1, 2024 12:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4392020
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4435111b-37dc-4ca4-a508-fd1190dbc67b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (key_value_component@a2d80d8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...UI/ExpandableSection/ExpandableSection.stories.tsx 0.00% 3 Missing ⚠️
...rmations/components/UI/InfoRow/InfoRow.stories.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##             key_value_component   #11528   +/-   ##
======================================================
  Coverage                       ?   53.88%           
======================================================
  Files                          ?     1647           
  Lines                          ?    38238           
  Branches                       ?     4653           
======================================================
  Hits                           ?    20603           
  Misses                         ?    16211           
  Partials                       ?     1424

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from key_value_component to main October 2, 2024 15:19
@jpuri jpuri dismissed matthewwalsh0’s stale review October 2, 2024 15:19

The base branch was changed.

@jpuri jpuri enabled auto-merge October 2, 2024 15:49
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 265099a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e305ea3-5059-4515-9ba0-723ace595d80

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8512a23
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31390420-9ad2-4a48-b7f9-c26a14e4b351

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 3, 2024
View reviewed changes
@jpuri jpuri requested a review from a team as a code owner October 3, 2024 09:46
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 74de008
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d828a865-5653-4137-98f8-b566a41bb9a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpuri jpuri added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 7f41cef Oct 4, 2024
36 of 37 checks passed
@jpuri jpuri deleted the expandable_section branch October 4, 2024 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create expandable card section
5 participants
@jpuri @codecov-commenter @pedronfigueiredo @matthewwalsh0 @EtherWizard33