Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow signing on permissioned account #11612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

elefantel
Copy link
Contributor

Description

This PR enables the account the dapp is connected to be able to sign when using the deeplinking communication layer of the iOS native SDK. Currently the account can sign if it is both the connected to account and the selected account.

Manual testing steps

  1. Request connection to MM wallet from dapp
  2. Choose any account other than the selected account as the account to connect to
  3. Then sign a message. The wallet should be able to sign using the account the dapp is connected to, regardless of whether it's the selected account or not.

Screenshots/Recordings

Before

before.MP4

After

after.MP4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 3, 2024
@elefantel elefantel self-assigned this Oct 3, 2024
@elefantel elefantel requested review from a team as code owners October 3, 2024 20:29
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sdk SDK team label Oct 3, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 3, 2024
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants