Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Token Sorting feature 🚧 #11618

Draft
wants to merge 3 commits into
base: feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Oct 4, 2024

Description

TBD

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-357

Manual testing steps

Go to Portfolio Screen
Sort should allow sorting by declining fiat balance, and alphabetic descending
Import button should function the same as the import token link in footer

Screenshots/Recordings

Screen.Recording.2024-10-03.at.10.37.36.PM.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added DO-NOT-MERGE Pull requests that should not be merged and removed team-assets labels Oct 4, 2024
@gambinish gambinish changed the title Feat/mmassets 357 sort import tokens mobile token sort config feat: Token Sorting feature 🚧 Oct 4, 2024
@gambinish gambinish changed the base branch from main to feat/mmassets_357-sort-import-tokens-mobile--reorg-portfolio-balance October 4, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant