fix: Fix unwanted IncompleteAssetDisplayed events

[OGPoyraz]

Description

This PR aims to stop IncompleteAssetDisplayed events appearing in the mix panel even the token is known by the API.

For more information please see the mixpanel link https://mixpanel.com/project/1979229/view/132079/app/events#H35NJuByTVqi

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3362

Manual testing steps

No QA needed

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[OGPoyraz]

The issue arises due to a race condition in the useBalanceChanges hook. Initially, the hook is invoked with empty balance changes (an empty array). Subsequently, simulationData gets populated and the hook is called again. In the interim, the empty balance changes resolve and set pending to false. This results in the IncompleteAssetEvent being triggered because it mistakenly interprets the new contract information as having resolved.

I reviewed the SimulationDetails component and simulationData in the extension. It appears that SimulationDetails is never rendered when simulationData is undefined. This is likely because the transactions state changes do not occur immediately(there is a time to bounce in extension state), unlike in the mobile app where the transactions simulationData is not defined in the beginning of the confirmation.

Please refer to the logs I added at the top of SimulationDetails in the extension, which show that simulationData is always defined.

This fix is just imitating the behaviour of extension and fixes that race condition.