Feature/4768 action selector sheet #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptimize for network calls. Fetching from middle out beginning with selected account.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
commented
Aug 22, 2022
app/component-library/components/Sheet/SheetHeader/SheetHeader.styles.ts
Outdated
Show resolved
Hide resolved
| switch (type) { | ||
| case KeyringTypes.qr: | ||
| case KeyringTypes.simple: | ||
| yOffset += 102; |
There was a problem hiding this comment.
Export const from CellAccount instead
Cal-L
changed the title
Cal-L
added
the
needs-dev-review
jpcloureiro
reviewed
Aug 25, 2022
app/component-library/components-temp/SheetActions/SheetActions.styles.ts
Show resolved
Hide resolved
jpcloureiro
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4768
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist