Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PS] Patch controllers #5048

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Sep 28, 2022

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Patched controllers and added react-native-get-random-values lib

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

#4772

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner September 28, 2022 06:54
@Cal-L Cal-L changed the base branch from main to feature/4754-permission-system September 28, 2022 06:54
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 28, 2022
@Cal-L Cal-L changed the title Feature/4772 patch controllers [PS] Patch controllers Sep 28, 2022
@Cal-L Cal-L force-pushed the feature/4772-patch-controllers branch from 861199e to 1410855 Compare September 28, 2022 09:14
@Cal-L Cal-L changed the base branch from feature/4754-permission-system to feature/4773-fix-component-styles-for-ps September 28, 2022 18:45
Base automatically changed from feature/4773-fix-component-styles-for-ps to feature/4754-permission-system September 28, 2022 23:07
@Cal-L Cal-L merged commit 1282a68 into feature/4754-permission-system Sep 28, 2022
@Cal-L Cal-L deleted the feature/4772-patch-controllers branch September 28, 2022 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants