-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sepolia network #5458
Support sepolia network #5458
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this update. This looks good to me. 🙌🏾
Most controller packages have been updated to the versions included in the core monorepo v39 release. The keyring controller was the only package held back, due to the BigInt incompatibility. Most of the breaking changes are related to dropping support for Ropsten, Rinkeby, and Kovan. The other breaking changes do not affect mobile.
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @metamask/base-controller@1.1.1 |
CI is failing due to an audit issue, but this was fixed on |
This PR is no longer blocked since abi-utils was updated to support node 14 |
app/components/UI/ApproveTransactionHeader/__snapshots__/ApproveTransactionHeader.test.tsx.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @tommasini was looking out for this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good 🌮 🌮
Description
Add support for sepolia network
This PR have merged in it this PR
Proposed Solution
Add support for sepolia network and remove code with rinkeby, ropsten and kovan
Also removed deprecated warning when the user was on the deprecated test networks.
Added and changed test cases with Sepolia Network.
Screenshots/Recordings
(Update Sepolia Icon on the last commit)
Test Cases
Case1:
Case2:
Case3:
Recordings
Case4:
Importing ERC20 token on Sepolia and sending transaction - https://recordit.co/2gNSkJ4cRY and https://recordit.co/6jF4tZckR2
Case5:
connect to the test dapp and perform dapp interactions.
Interactions include: Creating token, approving tokens and contracts (1155's, Multisig, collectibles) performing a multisig
transaction - https://recordit.co/DIq4Df9B7w
Case 6:
user should not have the ability to edit or delete the sepolia network - https://recordit.co/iMuUdMA9V6
Case 7:
the API keys for sepolia should not be exposed in the RPC URL endpoint.
Case 8:
Rinkeby, Ropsten and Koran should no longer be in on the networks page: Settings > networks.
Issue
Progresses #5406
Checklist