Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e appium/fix browser test permission system #5611

Conversation

SamuelSalas
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

…wser-test-permission-system

 Please enter a commit message to explain why this merge is necessary,
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮 🌮

@SamuelSalas SamuelSalas force-pushed the e2e-appium/fix-browser-test-permission-system branch from 490d591 to ad52c43 Compare January 27, 2023 21:00
@cortisiko cortisiko linked an issue Jan 28, 2023 that may be closed by this pull request
@cortisiko cortisiko merged commit 1c4e7f3 into feature/4754-permission-system Jan 28, 2023
@cortisiko cortisiko deleted the e2e-appium/fix-browser-test-permission-system branch January 28, 2023 01:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix appium browser tests on the Permission System branch
2 participants