-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e appium/fix browser test permission system #5611
Merged
cortisiko
merged 14 commits into
feature/4754-permission-system
from
e2e-appium/fix-browser-test-permission-system
Jan 28, 2023
Merged
E2e appium/fix browser test permission system #5611
cortisiko
merged 14 commits into
feature/4754-permission-system
from
e2e-appium/fix-browser-test-permission-system
Jan 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wser-test-permission-system Please enter a commit message to explain why this merge is necessary,
…wser-test-permission-system Please enter a commit message to explain why this merge is necessary,
SamuelSalas
requested review from
Fatxx,
NicolasMassart,
chrisleewilcox and
Andepande
January 26, 2023 13:50
…wser-test-permission-system Please enter a commit message to explain why this merge is necessary,
cortisiko
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🌮 🌮
cortisiko
removed request for
Fatxx,
NicolasMassart,
chrisleewilcox and
Andepande
January 26, 2023 23:12
…wser-test-permission-system Please enter a commit message to explain why this merge is necessary,
SamuelSalas
force-pushed
the
e2e-appium/fix-browser-test-permission-system
branch
from
January 27, 2023 21:00
490d591
to
ad52c43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist