Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e appium folder structure change #5632

Merged
merged 6 commits into from
Jan 28, 2023
Merged

E2e appium folder structure change #5632

merged 6 commits into from
Jan 28, 2023

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Jan 27, 2023 •
edited by cortisiko
Loading

Description

  • Restructured the file structure of WDIO, making it easier to understand, navigate and implement tests

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Progresses https://github.com/MetaMask/mobile-planning/issues/577

@Andepande
Re-arranged wdio file structure
005ec4f 
Re-arranged wdio file structure & refactor imports
@Andepande
Added missing Address Input ID
fd2ecb2
@Andepande Andepande requested a review from a team as a code owner January 27, 2023 20:30
cortisiko
cortisiko approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @Andepande 🌮 🌮 🌮

@cortisiko cortisiko merged commit 3ddd171 into main Jan 28, 2023
@cortisiko cortisiko deleted the e2e-appium-folder-structure-change branch January 28, 2023 04:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@SamuelSalas SamuelSalas Awaiting requested review from SamuelSalas

Assignees
No one assigned
Labels
Appium team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andepande @cortisiko @gauthierpetetin