-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/4754 importing wallet via qr #5634
Merged
Cal-L
merged 15 commits into
feature/4754-permission-system
from
fix/4754-importing-wallet-via-qr
Feb 1, 2023
Merged
Fix/4754 importing wallet via qr #5634
Cal-L
merged 15 commits into
feature/4754-permission-system
from
fix/4754-importing-wallet-via-qr
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
added
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-mobile-client
labels
Jan 28, 2023
jpcloureiro
suggested changes
Jan 31, 2023
…/MetaMask/metamask-mobile into fix/4754-importing-wallet-via-qr
jpcloureiro
approved these changes
Feb 1, 2023
cortisiko
added
QA Passed
A successful QA run through has been done
and removed
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Feb 1, 2023
cortisiko
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮 🌮
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Issue reported by @olenapankina & @cortisiko where importing an account via QR scanning wasn't working when the QR scan is accessed through the account selector. This PR refactors the
ImportPrivateKey
component and fixes the originally found issue. Note - Import via QR code from the Wallet view is unaffected. That logic is separate.Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Test
Since this is based off of the Permission System branch, there are two main cases to test: