Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/4754 importing wallet via qr #5634

Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jan 28, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Issue reported by @olenapankina & @cortisiko where importing an account via QR scanning wasn't working when the QR scan is accessed through the account selector. This PR refactors the ImportPrivateKey component and fixes the originally found issue. Note - Import via QR code from the Wallet view is unaffected. That logic is separate.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Test
Since this is based off of the Permission System branch, there are two main cases to test:

  1. Ensure that the original issue is fixed. You should be able to import an account via scanning QR code when accessing it through the account selector.
  2. Ensure that importing via QR code while in the PS connect flow doesn't dismiss the account selector after you're done.

@Cal-L Cal-L requested a review from a team as a code owner January 28, 2023 02:09
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Jan 28, 2023
app/components/Nav/App/index.js Outdated Show resolved Hide resolved
app/components/UI/AccountRightButton/index.tsx Outdated Show resolved Hide resolved
app/components/UI/AccountRightButton/index.tsx Outdated Show resolved Hide resolved
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 1, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@Cal-L Cal-L merged commit 87216d6 into feature/4754-permission-system Feb 1, 2023
@Cal-L Cal-L deleted the fix/4754-importing-wallet-via-qr branch February 1, 2023 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants