Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger qrsigning modal using approval controller #6212

Merged

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Apr 19, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The main goal of this PR is to trigger the qrsigning modal using the approval controller aligning the approach across the existing modals.

Screenshots/Recordings

1_Pair_unpair_keystone_MetaMask.mp4
2-create-token-keystone-metamask_qLMEcbFz.mp4
3_Transfer_tokens_keystone_MetaMask.mp4
4_Transfer_token_without_gas_keystone_MetaMask.mp4
5_Sign_personal_typed_keystone_MetaMask.mp4
6_Forget_this_device_keystone_MetaMask.mp4

Second round of tests:

keystone_test_1.mp4
keystone_test_2.mp4
keystone_test_3.mp4

Issue
resolves: https://github.com/MetaMask/mobile-planning/issues/783

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

app/components/Nav/Main/RootRPCMethodsUI.js Outdated Show resolved Hide resolved
app/components/Nav/Main/RootRPCMethodsUI.js Outdated Show resolved Hide resolved
app/components/Nav/Main/RootRPCMethodsUI.js Outdated Show resolved Hide resolved
@OGPoyraz OGPoyraz force-pushed the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch 2 times, most recently from 5be4a92 to 3bdd40b Compare April 19, 2023 10:15
@vinistevam vinistevam force-pushed the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch from 3bdd40b to 6b8fa7e Compare May 3, 2023 17:59
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam force-pushed the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch from 16fe025 to 74e0b32 Compare May 4, 2023 11:43
@vinistevam vinistevam marked this pull request as ready for review May 4, 2023 14:27
@vinistevam vinistevam requested a review from a team as a code owner May 4, 2023 14:27
@cryptotavares cryptotavares marked this pull request as draft May 19, 2023 08:40
@vinistevam vinistevam force-pushed the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch from 9616ef7 to cb32458 Compare June 14, 2023 05:28
@vinistevam vinistevam force-pushed the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch 2 times, most recently from 259698f to 0b8a205 Compare June 15, 2023 15:16
@vinistevam vinistevam marked this pull request as ready for review June 15, 2023 15:38
@vinistevam vinistevam force-pushed the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch from 0b8a205 to bda93b9 Compare June 16, 2023 08:00
vinistevam
vinistevam previously approved these changes Jun 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@OGPoyraz OGPoyraz merged commit 96473d3 into main Jun 23, 2023
@OGPoyraz OGPoyraz deleted the feat/783-trigger-modal-using-approval-controller-on-qr-signing branch June 23, 2023 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
@metamaskbot metamaskbot added the release-7.3.0 Issue or pull request that will be included in release 7.3.0 label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.3.0 Issue or pull request that will be included in release 7.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants